Avatar
0
Huu Tuyen Nguyen Beginner
Tối ưu code
Mọi người tối ưu cho em dòng code này
if (objectRequest.getRequest().getRequestID() == null
|| objectRequest.getRequest().getRequestID().trim().isEmpty()) {
xmlRequest += "";
} else {
xmlRequest += "<RequestID>" + objectRequest.getRequest().getRequestID().trim()
+ " </RequestID>\r\n";
}
  • Answer
Remain: 5
2 Answers
Avatar
monkey Beginner
monkey Beginner
Đây em:

<span>String</span> requestId = objectRequest.getRequest().getRequestID();
<span>requestId</span> = requestId == null ? <span>""</span> : requestId.trim();
<span>if</span> (requestId.isEmpty()) {
    <span>xmlRequest</span> += <span>""</span>;
} <span>else</span> {
    <span>xmlRequest</span> += <span>"<RequestID>"</span> + requestId + <span>" </RequestID>\r\n"</span>;
}
  • 1
  • Reply
Avatar
tbl Beginner
tbl Beginner
String xmlRequestBase = " {} \r\n";
String requestId = objectRequest.getRequest().getRequestID();
requestId = requestId == null ? "" : requestId.trim();

String xmlRequest =  xmlRequestBase.replaceFirst("\{\}", requestId);
  • -2
  • Reply
Nếu lạm dụng replace nó sẽ làm giảm performance bạn ạ  –  monkey 1635449458000